Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSSL_TRACE9 missing arg9 #16060

Closed
wants to merge 1 commit into from
Closed

Fix OSSL_TRACE9 missing arg9 #16060

wants to merge 1 commit into from

Conversation

wongsyrone
Copy link
Contributor

fix OSSL_TRACE9 macro

Checklist
  • documentation is added or updated
  • tests are added or updated

@openssl-machine openssl-machine added hold: cla required The contributor needs to submit a license agreement and removed hold: cla required The contributor needs to submit a license agreement labels Jul 13, 2021
@paulidale
Copy link
Contributor

I agree that this would be trivial. Could you either "git commit --amend" and add the line "CLA: trivial" to the bottom of the commit message or submit a signed ICLA?

@wongsyrone
Fix OSSL_TRACE9 missing arg9
e300f76 
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>

CLA: trivial
@wongsyrone
Copy link
Contributor Author

Force pushed

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jul 13, 2021
@t-j-h t-j-h added the approval: done This pull request has the required number of approvals label Jul 13, 2021
@t-j-h
Copy link
Member

t-j-h commented Jul 13, 2021

Agree trivial.

@wongsyrone
Copy link
Contributor Author

First-time contributors need a maintainer to approve running workflows.

What should I do now?

@t-j-h
Copy link
Member

t-j-h commented Jul 13, 2021

There is nothing for you to do now. A 24-hour grace period happens where other committers can object to the change.
And then after that one of the committers will actually commit the code to the repository.

Thanks for your contribution.

It would be good to get a CLA in place for future contributions that are non-trivial in nature.

@paulidale paulidale self-assigned this Jul 13, 2021
@wongsyrone
Copy link
Contributor Author

It would be good to get a CLA in place for future contributions that are non-trivial in nature.

Can I comment in this PR to sign the CLA?

@paulidale
Copy link
Contributor

We need a paper / scanned copy emailed to us. Download the ICLA from here, fill it in and sign it and email back to legal@opensslfoundation.org. If your work is part of your employment, we also require a CCLA from your employer.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge cla: trivial One of the commits is marked as 'CLA: trivial' and removed approval: done This pull request has the required number of approvals labels Jul 14, 2021
@paulidale
Copy link
Contributor

Merged, thanks for the fix.

@paulidale paulidale closed this Jul 14, 2021
openssl-machine pushed a commit that referenced this pull request Jul 14, 2021
@wongsyrone @paulidale
Fix OSSL_TRACE9 missing arg9
4e0383d 
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>

CLA: trivial

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #16060)
@wongsyrone wongsyrone deleted the fix-trace branch July 14, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t-j-h t-j-h t-j-h approved these changes

@mspncp mspncp mspncp approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge cla: trivial One of the commits is marked as 'CLA: trivial' severity: fips change The pull request changes FIPS provider sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wongsyrone @paulidale @t-j-h @openssl-machine @levitte @mspncp