Fix EVP_MD_meth_dup and EVP_CIPHER_meth_dup #16159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the origin is set correctly when duping an EVP_MD or EVP_CIPHER. Fixes openssl#16157
mattcaswell
added
branch: master
|
@mattcaswell, isn't it worth adding an asan test according to #16157? |
github-actions
bot
added
the
severity: fips change
beldmit
added
approval: done
paulidale
approved these changes
Jul 26, 2021
|
Does this warrant a test case? |
Check that EVP_MD_meth_free() and EVP_CIPHER_meth_free() does actually free the data.
|
Test case added. Please reconfirm. |
|
no-deprecated failure seems relevant |
|
Fixup pushed to address the no-deprecated problem. |
|
Formal reapprove. |
paulidale
approved these changes
Jul 27, 2021
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged to master, thanks for this. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 27, 2021
Check that EVP_MD_meth_free() and EVP_CIPHER_meth_free() does actually free the data. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the origin is set correctly when duping an EVP_MD or EVP_CIPHER.
Fixes #16157