Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genpkey: -quiet doesn't take an argument #16240

Closed
wants to merge 1 commit into from
Closed

genpkey: -quiet doesn't take an argument #16240

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

Fixes #16238

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Aug 6, 2021
@paulidale paulidale added this to the 3.0.0 milestone Aug 6, 2021
@paulidale paulidale self-assigned this Aug 6, 2021
@paulidale paulidale added branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch hold: need otc decision The OTC needs to make a decision labels Aug 6, 2021
@paulidale
Copy link
Contributor Author

This is a behaviour change for 3.0 and 1.1.1.
What it doesn't currently is wrong but could be surprising if it changed.

@t8m
Copy link
Member

t8m commented Aug 6, 2021

Alternatively, just modify the help text and the manual page to -quiet <ignored> Do not output status while generating keys (For backwards compatibility it takes an argument which is ignored.)

@paulidale
Copy link
Contributor Author

I'd prefer to not continue the error. That -quiet takes an argument is a long standing bug. We should fix it not document it.

Although I'd prefer fixing this now, to avoid breaking things, I'm fine with fixing this post 3.0.

@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Aug 9, 2021
@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch hold: need otc decision The OTC needs to make a decision labels Aug 10, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Aug 11, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Aug 11, 2021
@paulidale
Copy link
Contributor Author

Merged to master.

@paulidale paulidale closed this Aug 12, 2021
@paulidale paulidale deleted the genpkey-16238 branch August 12, 2021 06:26
openssl-machine pushed a commit that referenced this pull request Aug 12, 2021
@paulidale
genpkey: -quiet doesn't take an argument
dbd0244 
Fixes #16238

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #16240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Problems with genpkey
4 participants
@paulidale @t8m @openssl-machine @t-j-h