Fix some documentation errors #16553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
paulidale
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
I think this is within the bounds of being trivial.
You will need the CLA: trivial line in the commit message, not the GitHub pull request. git commit --amend will let you edit the message -- just add a the required line. git push -f will push the modified message here and the need CLA tag should disappear.
CLA: trivial
PeiweiHu
force-pushed
the
PeiweiHu-Patch3_1
branch
from
4b6d592
to
0aff8c6
Compare
openssl-machine
removed
the
hold: cla required
t8m
approved these changes
Sep 8, 2021
t8m
added
branch: 3.0
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 9, 2021
CLA: trivial Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #16553)
|
Merged to master and 3.0 branches. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA:trivial
There are 3 changes within the pr:
Fix documentation: doc/man3/OSSL_HTTP_REQ_CTX.pod
Function OSSL_HTTP_REQ_CTX_free will free wbio if rctx->free_wbio is set while documentation says The wbio and rbio are not free'd. This may lead to misuse of freed object.
Fix documentation: doc/man3/OSSL_CMP_MSG_get0_header.pod
Old function defination of OSSL_CMP_MSG_read. Note that some other new functions origins from commit c631378 may also need to be added to documentation.
Fix documentation: doc/man3/ASN1_item_d2i_bio.pod
Some parameters' names are not consistent with source code.
Checklist