Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return value of BIO_free #16682

Closed
wants to merge 1 commit into from
Closed

Fix return value of BIO_free #16682

wants to merge 1 commit into from

Conversation

PeiweiHu
Copy link
Contributor

CLA: trivial

Since the docuementation says BIO_free() return 1 for success and 0 for failure and some other applications who use openssl library are used to use if(!BIO_free) {, it's better to unify return value.

Checklist
  • documentation is added or updated
  • tests are added or updated

paulidale
paulidale approved these changes Sep 26, 2021
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, trivial.

@paulidale paulidale added approval: review pending This pull request needs review by a committer branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' labels Sep 26, 2021
t8m
t8m approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with CLA: trivial

@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer labels Sep 27, 2021
@t8m
Copy link
Member

t8m commented Sep 27, 2021

IMO this is a bug fix and should be backported.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale paulidale added the branch: 3.0 Merge to openssl-3.0 branch label Sep 28, 2021
openssl-machine pushed a commit that referenced this pull request Sep 28, 2021
@PeiweiHu @paulidale
Fix return value of BIO_free
d8f6c53 
CLA: trivial

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #16682)
openssl-machine pushed a commit that referenced this pull request Sep 28, 2021
@PeiweiHu @paulidale
Fix return value of BIO_free
51b5e8b 
CLA: trivial

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #16682)

(cherry picked from commit d8f6c53)
@paulidale
Copy link
Contributor

Merged to 3.0 and master.

@paulidale paulidale closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeiweiHu @t8m @openssl-machine @paulidale