Fix incorrect return check of BN_bn2nativepad

[PeiweiHu]

Checklist

• documentation is added or updated
• tests are added or updated

[kroeckx]

Could you update the documentation to say that BN_bn2lebinpad and BN_bn2nativepad also return -1 when the buffer is too small?

[PeiweiHu]

Could you update the documentation to say that BN_bn2lebinpad and BN_bn2nativepad also return -1 when the buffer is too small?

I put them together with BN_bn2binpad. It seems they invoke the same inner interface.

[t8m]

This won't apply to 1.1.1. IMO it is also not worth backporting to 1.1.1 as the code fix is only for 3.0.

[kroeckx]

The documentation will apply to 1.1.1 too, I think

[t8m]

The documentation will apply to 1.1.1 too, I think

Yes, but IMO we are not aiming to fix all documentation deficiencies in 1.1.1.

[kroeckx]

Yes, but IMO we are not aiming to fix all documentation deficiencies in 1.1.1.

1.1.1 is our current LTS release.

[t8m]

Anyway if someone submits a 1.1.1 PR, no problem.

[openssl-machine]

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

[t8m]

Merged to master and 3.0 branches. Thank you for the contribution.