Fix: invoking BN_check_prime improperly #16975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
severity: fips change
t8m
approved these changes
Nov 5, 2021
t8m
added
approval: review pending
paulidale
approved these changes
Nov 5, 2021
paulidale
added
approval: done
kroeckx
approved these changes
Nov 5, 2021
kroeckx
reviewed
Nov 5, 2021
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
kroeckx
removed
the
approval: ready to merge
paulidale
approved these changes
Nov 11, 2021
t8m
approved these changes
Nov 11, 2021
t8m
added
the
approval: done
paulidale
approved these changes
Nov 11, 2021
kroeckx
approved these changes
Nov 11, 2021
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Nov 12, 2021
Negative return value indicates an error so we bail out. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #16975)
|
Squashed and merged to master and 3.0 branches. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BN_is_prime_fasttest() and BN_check_prime return 0 if the number is composite,
1 if it is prime with an error probability of less than 0.25^B, and
-1 on error.
Binary check of BN_check_prime will mix -1 and 1.
In fact, I am not that confident this is wrong, just suspicious. Say sorry for bothering beforehand if it's not a bug.
Checklist