Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVP_DigestVerifyFinal: fix test function and invocation #17029

Closed
wants to merge 1 commit into from
Closed

EVP_DigestVerifyFinal: fix test function and invocation #17029

wants to merge 1 commit into from

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Nov 14, 2021 •
edited

EVP_DigestVerifyFinal can return the negative values to indicate errors.

EVP_DigestVerifyFinal() and EVP_DigestVerify() return 1 for success; any other
value indicates failure. A return value of zero indicates that the signature
did not verify successfully (that is, B did not match the original data or
the signature had an invalid form), while other values indicate a more serious
error (and sometimes also indicate an invalid signature form).

Checklist
  • documentation is added or updated
  • tests are added or updated

@PeiweiHu
EVP_DigestVerifyFinal: fix test function and invocation
6405ae1 
Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>
mattcaswell
mattcaswell approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Which branches does this apply to?

@mattcaswell mattcaswell added branch: 3.0 Merge to openssl-3.0 branch branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Nov 15, 2021
@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer labels Nov 15, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 16, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Nov 16, 2021
@PeiweiHu @t8m
EVP_DigestVerifyFinal: fix test function and invocation
ee3928f 
Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17029)

(cherry picked from commit e2e5e72)
openssl-machine pushed a commit that referenced this pull request Nov 16, 2021
@PeiweiHu @t8m
EVP_DigestVerifyFinal: fix test function and invocation
e2e5e72 
Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17029)
@t8m
Copy link
Member

t8m commented Nov 16, 2021

Merged to master and 3.0 branches. Thank you for your contribution.

@t8m t8m closed this Nov 16, 2021
ramikhaldi pushed a commit to ramikhaldi/openssl that referenced this pull request Nov 21, 2021
@PeiweiHu @rkhaldi
EVP_DigestVerifyFinal: fix test function and invocation
f4564a5 
Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PeiweiHu @openssl-machine @t8m @mattcaswell @paulidale