Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/cmp_vfy_test.c: free before return #17279

Closed
wants to merge 1 commit into from
Closed

test/cmp_vfy_test.c: free before return #17279

wants to merge 1 commit into from

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Dec 15, 2021 •
edited by t8m

ChecklistQ
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added approval: review pending This pull request needs review by a committer branch: 3.0 Merge to openssl-3.0 branch branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug labels Dec 15, 2021
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 16, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 17, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Dec 17, 2021
@PeiweiHu @t8m
test/cmp_vfy_test.c: free before return
869b7dd 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17279)
@t8m
Copy link
Member

t8m commented Dec 17, 2021

@PeiweiHu when editing files, please verify that you do not keep trailing spaces as with this patch. Unfortunately github diff view does not show them prominently. You can easily verify with git diff as the trailing spaces are shown in red.

@t8m
Copy link
Member

t8m commented Dec 17, 2021

Merged to master and 3.0 branches (after removing the trailing spaces). Thank you.

@t8m t8m closed this Dec 17, 2021
openssl-machine pushed a commit that referenced this pull request Dec 17, 2021
@PeiweiHu @t8m
test/cmp_vfy_test.c: free before return
e7d55e3 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17279)

(cherry picked from commit 869b7dd)
@PeiweiHu
Copy link
Contributor Author

Thanks for your reminder. I will keep my eyes open next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeiweiHu @openssl-machine @t8m @paulidale