Remove further uses of __ARMEL__ in AArch64 assembly #17988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sweep of the source tree in openssl#17373 missed the BSAES assembly due its PR openssl#14592 having been temporarily backed out at the time. This constitutes a partial fix for openssl#17958 - covers cases except when configured with -DOPENSSL_AES_CONST_TIME.
github-actions
bot
added
the
severity: fips change
mattcaswell
approved these changes
Mar 29, 2022
mattcaswell
added
branch: master
t8m
approved these changes
Mar 29, 2022
t8m
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged to master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 30, 2022
The sweep of the source tree in #17373 missed the BSAES assembly due its PR #14592 having been temporarily backed out at the time. This constitutes a partial fix for #17958 - covers cases except when configured with -DOPENSSL_AES_CONST_TIME. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #17988)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 4, 2022
The sweep of the source tree in openssl#17373 missed the BSAES assembly due its PR openssl#14592 having been temporarily backed out at the time. This constitutes a partial fix for openssl#17958 - covers cases except when configured with -DOPENSSL_AES_CONST_TIME. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17988) (cherry picked from commit 2bd5cde)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 4, 2022
The sweep of the source tree in openssl#17373 missed the BSAES assembly due its PR openssl#14592 having been temporarily backed out at the time. This constitutes a partial fix for openssl#17958 - covers cases except when configured with -DOPENSSL_AES_CONST_TIME. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17988) (cherry picked from commit 2bd5cde)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 9, 2022
The sweep of the source tree in openssl#17373 missed the BSAES assembly due its PR openssl#14592 having been temporarily backed out at the time. This constitutes a partial fix for openssl#17958 - covers cases except when configured with -DOPENSSL_AES_CONST_TIME. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17988) (cherry picked from commit 2bd5cde)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 11, 2022
The sweep of the source tree in #17373 missed the BSAES assembly due its PR #14592 having been temporarily backed out at the time. This constitutes a partial fix for #17958 - covers cases except when configured with -DOPENSSL_AES_CONST_TIME. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #17988) (cherry picked from commit 2bd5cde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sweep of the source tree in #17373 missed the BSAES assembly due its
PR #14592 having been temporarily backed out at the time.
This partially fixes #17958 - covers cases except when
configured with -DOPENSSL_AES_CONST_TIME.