Avoid undefined behavior of provided macs on EVP_MAC reinitialization #18100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the context is reinitialized, i.e. the same key should be used we must properly reinitialize the underlying implementation. However in POLY1305 case it does not make sense as this special MAC should not reuse keys. We fail with this provided implementation when reinitialization happens. Fixes openssl#17811
t8m
added
branch: master
github-actions
bot
added
the
severity: fips change
|
Aargh, we apparently depend on EVP_MAC_init() not failing even for the POLY1305 mac. |
|
Yeah, here: Lines 183 to 186 in 801c638 The key is passed as a param not via this call. I prefer the way you are heading but it means an API break :( |
I think it can be avoided - done in the fixup. |
|
CI is green |
mattcaswell
reviewed
Apr 13, 2022
mattcaswell
approved these changes
Apr 13, 2022
mattcaswell
removed
the
approval: otc review pending
paulidale
approved these changes
Apr 13, 2022
paulidale
removed
the
approval: review pending
t8m
added
the
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master and 3.0 branches. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 19, 2022
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #18100)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 19, 2022
When the context is reinitialized, i.e. the same key should be used we must properly reinitialize the underlying implementation. However in POLY1305 case it does not make sense as this special MAC should not reuse keys. We fail with this provided implementation when reinitialization happens. Fixes #17811 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #18100)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 19, 2022
When the context is reinitialized, i.e. the same key should be used we must properly reinitialize the underlying implementation. However in POLY1305 case it does not make sense as this special MAC should not reuse keys. We fail with this provided implementation when reinitialization happens. Fixes #17811 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #18100) (cherry picked from commit c9ddc5a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the context is reinitialized, i.e. the same key should be used
we must properly reinitialize the underlying implementation.
However in POLY1305 case it does not make sense as this special MAC
should not reuse keys. We fail with this provided implementation
when reinitialization happens.
Fixes #17811
Checklist