Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poly1305: Properly copy the whole context on dup #18143

Closed
wants to merge 1 commit into from
Closed

poly1305: Properly copy the whole context on dup #18143

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 21, 2022

Also reset the updated flag when Poly1305_Init is called.

This improves the fix from PR #18100

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.0 Merge to openssl-3.0 branch labels Apr 21, 2022
@t8m
poly1305: Properly copy the whole context on dup
138523c 
Also reset the updated flag when Poly1305_Init is called.
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Apr 21, 2022
@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Apr 25, 2022
@t8m
Copy link
Member Author

t8m commented Apr 27, 2022

Ping for the second review

@t8m t8m requested a review from mattcaswell April 27, 2022 08:10
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 27, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 28, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged.

@paulidale paulidale closed this Apr 29, 2022
openssl-machine pushed a commit that referenced this pull request Apr 29, 2022
@t8m @paulidale
poly1305: Properly copy the whole context on dup
e661cc4 
Also reset the updated flag when Poly1305_Init is called.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18143)

(cherry picked from commit bbe909d)
openssl-machine pushed a commit that referenced this pull request Apr 29, 2022
@t8m @paulidale
poly1305: Properly copy the whole context on dup
bbe909d 
Also reset the updated flag when Poly1305_Init is called.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @openssl-machine @paulidale @mattcaswell