Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the checks of several functions #18369

Closed
wants to merge 8 commits into from
Closed

Fix the checks of several functions #18369

wants to merge 8 commits into from

Conversation

PeiweiHu
Copy link
Contributor

Checklist
  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels May 23, 2022
t8m
t8m reviewed May 23, 2022
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if in many cases (non-public interfaces) it would be better to just ensure those calls return 0 or 1 inside those functions.

tmshort
tmshort previously approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 23, 2022
t8m
t8m requested changes May 23, 2022
View reviewed changes
crypto/x509/v3_addr.c Outdated Show resolved Hide resolved
crypto/x509/v3_addr.c Outdated Show resolved Hide resolved
ssl/record/rec_layer_d1.c Outdated Show resolved Hide resolved
ssl/record/ssl3_record.c Outdated Show resolved Hide resolved
ssl/record/ssl3_record.c Outdated Show resolved Hide resolved
ssl/statem/statem_clnt.c Outdated Show resolved Hide resolved
ssl/statem/statem_srvr.c Outdated Show resolved Hide resolved
@PeiweiHu PeiweiHu requested a review from t8m May 23, 2022 16:04
@PeiweiHu
Copy link
Contributor Author

Thanks for the reviews. Changed already.

@paulidale paulidale added approval: review pending This pull request needs review by a committer and removed approval: done This pull request has the required number of approvals labels May 24, 2022
@t8m
Copy link
Member

t8m commented May 24, 2022

Approved. I propose squashing the commits when merging as the last commit partially reverts the previous changes.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 24, 2022
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label May 25, 2022
@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label May 25, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged to both after squashing.

@paulidale paulidale closed this May 26, 2022
openssl-machine pushed a commit that referenced this pull request May 26, 2022
@PeiweiHu @paulidale
Fix check of dtls1_process_record
c77eb85 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18369)

(cherry picked from commit 639e576)
openssl-machine pushed a commit that referenced this pull request May 26, 2022
@PeiweiHu @paulidale
Fix check of dtls1_process_record
639e576 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@tmshort tmshort tmshort left review comments

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PeiweiHu @t8m @openssl-machine @paulidale @tmshort