Fix undefined ipi_spec_dst for cygwin build. #19134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
|
FYI: ICLA was submitted right before sending the pull request, but it probably needs some time to be processed. |
t8m
added
branch: master
hlandau
approved these changes
Sep 6, 2022
hlandau
removed
the
approval: review pending
t8m
approved these changes
Sep 7, 2022
t8m
added
approval: done
openssl-machine
removed
the
hold: cla required
t8m
added
approval: done
The 'struct in_pktinfo' doesn't have a 'ipi_spec_dst' field on windows OS which break cygwin builds of OpenSSL. Signed-off-by: Tristan Lelong <tlelong@google.com>
blunderer
force-pushed
the
fix-cygwin-build
branch
from
60d4591
to
8a94490
Compare
|
I rebased the branch against openssl/master, and the CLA required flag was removed. |
|
Still OK |
t8m
added
approval: ready to merge
|
Merged to master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 8, 2022
The 'struct in_pktinfo' doesn't have a 'ipi_spec_dst' field on windows OS which break cygwin builds of OpenSSL. Signed-off-by: Tristan Lelong <tlelong@google.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19134)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
The 'struct in_pktinfo' doesn't have a 'ipi_spec_dst' field on windows OS which break cygwin builds of OpenSSL. Signed-off-by: Tristan Lelong <tlelong@google.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19134)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
The 'struct in_pktinfo' doesn't have a 'ipi_spec_dst' field on windows OS which break cygwin builds of OpenSSL. Signed-off-by: Tristan Lelong <tlelong@google.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'struct in_pktinfo' doesn't have a 'ipi_spec_dst' field on windows
OS which break cygwin builds of OpenSSL.
Signed-off-by: Tristan Lelong tlelong@google.com