Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BIO_sendmmsg/BIO_recvmmsg issues on FreeBSD #19164

Closed
wants to merge 1 commit into from
Closed

Fix BIO_sendmmsg/BIO_recvmmsg issues on FreeBSD #19164

wants to merge 1 commit into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Sep 7, 2022

Fixes #19156.

@hlandau hlandau added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending triaged: bug The issue/pr is/fixes a bug labels Sep 7, 2022
@hlandau hlandau self-assigned this Sep 7, 2022
@hlandau hlandau mentioned this pull request Sep 7, 2022
Closed
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 8, 2022
@levitte
Copy link
Member

levitte commented Sep 8, 2022

Close/open to have the buildbot workers kick in

@levitte levitte closed this Sep 8, 2022
@levitte levitte reopened this Sep 8, 2022
@levitte
Copy link
Member

levitte commented Sep 8, 2022

Never mind buildbot/master:unix-centos8-x86_64 and bulidbot/master:unix-ubuntu2004-x86_64, they are currently paused.
I removed their jobs from the build request queues, but that doesn't seem to be reflected here, unfortunately.

@levitte levitte mentioned this pull request Sep 8, 2022
Closed
2 tasks
@levitte
Copy link
Member

levitte commented Sep 8, 2022

I'd like to make this urgent, considering that we now have buildbot jobs failing because of the lack of this fix.

Anyone disagree?

@t8m
Copy link
Member

t8m commented Sep 8, 2022

OK with urgent.

@t8m t8m added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Sep 8, 2022
@hlandau
Copy link
Member Author

hlandau commented Sep 8, 2022

Agree urgent.

@levitte
Copy link
Member

levitte commented Sep 8, 2022

Please go ahead

@hlandau
Copy link
Member Author

hlandau commented Sep 8, 2022

Merging.

@hlandau
Copy link
Member Author

hlandau commented Sep 8, 2022

Merged to master.

@hlandau hlandau closed this Sep 8, 2022
openssl-machine pushed a commit that referenced this pull request Sep 8, 2022
@hlandau
Fix BIO_sendmmsg/BIO_recvmmsg issues on FreeBSD
0768779 
Fixes #19156.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19164)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@hlandau @sftcd
Fix BIO_sendmmsg/BIO_recvmmsg issues on FreeBSD
45d0c76 
Fixes openssl#19156.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19164)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@hlandau @beldmit
Fix BIO_sendmmsg/BIO_recvmmsg issues on FreeBSD
695869e 
Fixes openssl#19156.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@mattcaswell mattcaswell Awaiting requested review from mattcaswell

Assignees

@hlandau hlandau

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures on FreeBSD
4 participants
@hlandau @levitte @t8m @paulidale