Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl.cnf: split option value and comment #19173

Closed
wants to merge 2 commits into from
Closed

openssl.cnf: split option value and comment #19173

wants to merge 2 commits into from

Conversation

a1346054
Copy link
Contributor

@a1346054 a1346054 commented Sep 8, 2022

No description provided.

CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>
CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>
@mattcaswell mattcaswell added branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' labels Sep 8, 2022
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is trivial

@mattcaswell mattcaswell added the approval: review pending This pull request needs review by a committer label Sep 8, 2022
@t8m t8m added the triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly label Sep 8, 2022
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with CLA: trivial

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 8, 2022
@paulidale
Copy link
Contributor

agreed, trivial

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m
Copy link
Member

t8m commented Sep 9, 2022

Squashed and merged the commits to master branch. Thank you for your contribution.

@t8m t8m closed this Sep 9, 2022
openssl-machine pushed a commit that referenced this pull request Sep 9, 2022
CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19173)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19173)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19173)

(cherry picked from commit fd24de9)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19173)

(cherry picked from commit fd24de9)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
CLA: trivial

Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19173)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants