Fix the OSSL_TIME fallback in include/internal/e_os.h #19214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a fallback `ossl_sleep()` that uses `OSSL_TIME`. However, nothing was done to ensure that `OSSL_TIME` is defined. Adding an inclusion of "internal/time.h" should be enough.
levitte
added
approval: otc review pending
approval: review pending
|
Marked urgent, because of current compilation failure on VMS Ref: https://ci.buildbot.openssl.org/#/builders/2/builds/70/steps/7/logs/stdio |
github-actions
bot
added
the
severity: fips change
mattcaswell
approved these changes
Sep 14, 2022
|
Agree urgent. |
mattcaswell
added
approval: ready to merge
|
Merged eb51673 Fix the OSSL_TIME fallback in include/internal/e_os.h |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 14, 2022
There's a fallback `ossl_sleep()` that uses `OSSL_TIME`. However, nothing was done to ensure that `OSSL_TIME` is defined. Adding an inclusion of "internal/time.h" should be enough. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #19214)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
There's a fallback `ossl_sleep()` that uses `OSSL_TIME`. However, nothing was done to ensure that `OSSL_TIME` is defined. Adding an inclusion of "internal/time.h" should be enough. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#19214)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
There's a fallback `ossl_sleep()` that uses `OSSL_TIME`. However, nothing was done to ensure that `OSSL_TIME` is defined. Adding an inclusion of "internal/time.h" should be enough. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#19214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a fallback
ossl_sleep()that usesOSSL_TIME. However,nothing was done to ensure that
OSSL_TIMEis defined.Adding an inclusion of "internal/time.h" should be enough.