APPS {storeutl,gendsa}: give error on extra arguments, improve doc
#20156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed types of contents
Point out that options must be given before the final file/URI arg.
DDvO
added
branch: master
DDvO
changed the title
storeutl,gendsa`}: give error on extra arguments, improve docstoreutl,gendsa}: give error on extra arguments, improve doc
t8m
removed
branch: 3.0
|
This won't cherry pick to older branches. |
|
I'd suggest doing just a docfix PR for 3.1/3.0 |
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Jan 31, 2023
…e ignored ... and therefore all options must be given before the final file/URI arg. This is essentially a backport of the doc portion of openssl#20156 to 3.0 and 3.1, where the missing error checking/reporting likely will not be added.
1 task
Ah, right.
Done in #20179. |
t8m
approved these changes
Jan 31, 2023
paulidale
approved these changes
Jan 31, 2023
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 2, 2023
…e ignored ... and therefore all options must be given before the final file/URI arg. This is essentially a backport of the doc portion of #20156 to 3.0 and 3.1, where the missing error checking/reporting likely will not be added. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #20179) (cherry picked from commit 36d85b0)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 2, 2023
…e ignored ... and therefore all options must be given before the final file/URI arg. This is essentially a backport of the doc portion of #20156 to 3.0 and 3.1, where the missing error checking/reporting likely will not be added. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #20179)
|
Merged to master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 2, 2023
…ed types of contents Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #20156)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 2, 2023
Point out that options must be given before the final file/URI arg. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #20156)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point out that CLI options must be given before the final file/URI arg.
So far, they were silently ignored, as well as any extra args.
Also fix in the
storeutldoc that there is only one URI arg.On this occasion, also improve APPS
load_key_certs_crls()diagnostics on not finding expected types of contents.Fixes #20144.
Checklist