Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert: "Put EdDSA back as approved algorithms." #20343

Closed
wants to merge 3 commits into from
Closed

Revert: "Put EdDSA back as approved algorithms." #20343

wants to merge 3 commits into from

Conversation

paulidale
Copy link
Contributor

@paulidale paulidale commented Feb 20, 2023 •
edited

NIST isn't allowing EdDSA at this stage after all, so make it non-FIPS in the FIPS provider. Guidance for FIPS 140-3 is expected later this month:

The use of EdDSA still remains non-approved.

Before the FIPS 186-5 and SP 800-186 algorithms / curves can be used in the approved mode, the CMVP will need to do (at least) the following:

  • Incorporate FIPS 186-5 and SP 800-186 into SP 800-140C/D;
  • Update IG 10.3.A to incorporate self-test requirements for the new algorithms/curves.
  • Write a new IG on this transition to clarify the issues raised in this thread and elsewhere and provide a clear transition schedule.

The CMVP is working on all three of these items and hope to have drafts public by the end of March.

Since security relevant changes are not permitted for new 140-2 submissions, and under the assumption that this transition away from FIPS 186-4 algorithms will be 'soft' and not move modules to the historical list, we do not plan on writing 140-2 guidance for this transition.

It seems unlikely that all of these requirements will be completed before we submit.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Feb 20, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Feb 20, 2023
hlandau
hlandau approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@hlandau hlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a shame... oh well.

@hlandau hlandau removed the approval: otc review pending This pull request needs review by an OTC member label Feb 21, 2023
@paulidale
Copy link
Contributor Author

They'll be back, just not for our first 140-3 validation 😞

@paulidale paulidale added this to the 3.1.0 milestone Feb 21, 2023
slontis
slontis approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh..

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 21, 2023
@slontis
Copy link
Member

slontis commented Feb 21, 2023

@paulidale Can you confirm what you meant by the statement 'NIST isn't allowing EdDSA at this stage after all, so remove it from the FIPS provider.'

You have not removed it.. You have changed it to not have fips=true.

@paulidale
Revert "Put EdDSA back as approved algorithms."
b1fe64f 
This reverts commit 09627a8.

NIST isn't allowing EdDSA at this stage after all, so flag it as not
FIPS approved in the FIPS provider.  Guidance for FIPS 140-3 is expected
later this month:

    The use of EdDSA still remains non-approved.

    Before the FIPS 186-5 and SP 800-186 algorithms / curves can be
    used in the approved mode, the CMVP will need to do (at least)
    the following:

    * Incorporate FIPS 186-5 and SP 800-186 into SP 800-140C/D;

    * Update IG 10.3.A to incorporate self-test requirements for the
      new algorithms/curves.

    * Write a new IG on this transition to clarify the issues raised in
      this thread and elsewhere and provide a clear transition schedule.

    The CMVP is working on all three of these items and hope to have
    drafts public by the end of March.

    Since security relevant changes are not permitted for new 140-2
    submissions, and under the assumption that this transition away
    from FIPS 186-4 algorithms will be 'soft' and not move modules to
    the historical list, we do not plan on writing 140-2 guidance for
    this transition.

It seems unlikely that all of these requirements will be completed before
we submit.
@paulidale
update changes entry to note EdDSA is not FIPS approved
63bf3b5
@paulidale
update documentation to note that EdDSA is not FIPS approved
5b9299d
@paulidale
Copy link
Contributor Author

Read the description which includes NIST's comments and you'll know as much as I do.

I've updated what I wrote to indicate not approved rather than removed.

@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Feb 22, 2023
@paulidale paulidale deleted the eddsa-continued branch February 22, 2023 00:30
openssl-machine pushed a commit that referenced this pull request Feb 22, 2023
@paulidale
Revert "Put EdDSA back as approved algorithms."
759ab59 
This reverts commit 09627a8.

NIST isn't allowing EdDSA at this stage after all, so flag it as not
FIPS approved in the FIPS provider.  Guidance for FIPS 140-3 is expected
later this month:

    The use of EdDSA still remains non-approved.

    Before the FIPS 186-5 and SP 800-186 algorithms / curves can be
    used in the approved mode, the CMVP will need to do (at least)
    the following:

    * Incorporate FIPS 186-5 and SP 800-186 into SP 800-140C/D;

    * Update IG 10.3.A to incorporate self-test requirements for the
      new algorithms/curves.

    * Write a new IG on this transition to clarify the issues raised in
      this thread and elsewhere and provide a clear transition schedule.

    The CMVP is working on all three of these items and hope to have
    drafts public by the end of March.

    Since security relevant changes are not permitted for new 140-2
    submissions, and under the assumption that this transition away
    from FIPS 186-4 algorithms will be 'soft' and not move modules to
    the historical list, we do not plan on writing 140-2 guidance for
    this transition.

It seems unlikely that all of these requirements will be completed before
we submit.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #20343)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2023
@paulidale
update changes entry to note EdDSA is not FIPS approved
8c02b98 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #20343)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2023
@paulidale
update documentation to note that EdDSA is not FIPS approved
fdd4716 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #20343)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2023
@paulidale
Revert "Put EdDSA back as approved algorithms."
a4720e9 
This reverts commit 09627a8.

NIST isn't allowing EdDSA at this stage after all, so flag it as not
FIPS approved in the FIPS provider.  Guidance for FIPS 140-3 is expected
later this month:

    The use of EdDSA still remains non-approved.

    Before the FIPS 186-5 and SP 800-186 algorithms / curves can be
    used in the approved mode, the CMVP will need to do (at least)
    the following:

    * Incorporate FIPS 186-5 and SP 800-186 into SP 800-140C/D;

    * Update IG 10.3.A to incorporate self-test requirements for the
      new algorithms/curves.

    * Write a new IG on this transition to clarify the issues raised in
      this thread and elsewhere and provide a clear transition schedule.

    The CMVP is working on all three of these items and hope to have
    drafts public by the end of March.

    Since security relevant changes are not permitted for new 140-2
    submissions, and under the assumption that this transition away
    from FIPS 186-4 algorithms will be 'soft' and not move modules to
    the historical list, we do not plan on writing 140-2 guidance for
    this transition.

It seems unlikely that all of these requirements will be completed before
we submit.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #20343)

(cherry picked from commit 759ab59)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2023
@paulidale
update changes entry to note EdDSA is not FIPS approved
098e655 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #20343)

(cherry picked from commit 8c02b98)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2023
@paulidale
update documentation to note that EdDSA is not FIPS approved
73b0126 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #20343)

(cherry picked from commit fdd4716)
@slontis
Copy link
Member

slontis commented Feb 22, 2023

@paulidale Do you need to look at the entries in encoders.inc and decoders.inc also?

@paulidale
Copy link
Contributor Author

Outside the boundary 😁

@xnox
Copy link
Contributor

xnox commented Apr 10, 2024

@paulidale Do you need to look at the entries in encoders.inc and decoders.inc also?

not cryptographic algorithms - as it's pure mechanical data translation / marshaling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulidale @slontis @xnox @hlandau