Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert additional dupctx support in provided ciphers in 3.1 #22081

Closed
wants to merge 5 commits into from
Closed

Revert additional dupctx support in provided ciphers in 3.1 #22081

wants to merge 5 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Sep 12, 2023

The CI on 3.1 is broken due to this so marking this urgent.

@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Sep 12, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 12, 2023
@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Sep 12, 2023
@t8m
Copy link
Member Author

t8m commented Sep 13, 2023

@paulidale OK with urgent?

@t8m t8m requested a review from a team September 13, 2023 05:28
mattcaswell
mattcaswell approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with urgent

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 13, 2023
@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 13, 2023
@t8m
Copy link
Member Author

t8m commented Sep 13, 2023

Merged to 3.1 branch. Thank you for the reviews.

@t8m t8m closed this Sep 13, 2023
openssl-machine pushed a commit that referenced this pull request Sep 13, 2023
@t8m
Revert "Add dupctx support to rc4_hmac_md5 algo"
a1c0a20 
This reverts commit d9f84ae.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22081)
openssl-machine pushed a commit that referenced this pull request Sep 13, 2023
@t8m
Revert "implement dupctx for chacha20_poly1305"
1222f37 
This reverts commit 603b4c3.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22081)
openssl-machine pushed a commit that referenced this pull request Sep 13, 2023
@t8m
Revert "implement dupctx for aes_WRAP methods"
78732d8 
This reverts commit 819ae76.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22081)
openssl-machine pushed a commit that referenced this pull request Sep 13, 2023
@t8m
Revert "Add dupctx support to aead ciphers"
d74ef8d 
This reverts commit a982016.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22081)
openssl-machine pushed a commit that referenced this pull request Sep 13, 2023
@t8m
Revert "make inability to dup/clone ciphers an error"
094c929 
This reverts commit d739b3e.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22081)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@t8m
Revert "Add dupctx support to rc4_hmac_md5 algo"
f2c4ab0 
This reverts commit d9f84aef6033804e4c7ebf28ee88fcd2c63161d6.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22081)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@t8m
Revert "implement dupctx for chacha20_poly1305"
cac4e56 
This reverts commit 603b4c332f817cfc14a0d8b30d1e5a198f575644.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22081)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@t8m
Revert "implement dupctx for aes_WRAP methods"
48dca7f 
This reverts commit 819ae76bb76540a4321e548851e23099ddf71e8e.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22081)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@t8m
Revert "Add dupctx support to aead ciphers"
9ad92af 
This reverts commit a982016c56f8c631e0906b0a33f4feaf3d20a2ff.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22081)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@t8m
Revert "make inability to dup/clone ciphers an error"
9c27b68 
This reverts commit d739b3e05e749d4310b7310c007a4f3b8d5f8556.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22081)

Signed-off-by: fly2x <fly2x@hitls.org>
@alex alex mentioned this pull request Dec 9, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.1 Merge to openssl-3.1 severity: fips change The pull request changes FIPS provider sources severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t8m @mattcaswell @paulidale