Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos found by codespell in openssl-3.1 #23544

Closed
wants to merge 1 commit into from
Closed

Fix typos found by codespell in openssl-3.1 #23544

wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

Only modify doc/man* in the openssl-3.1 branch.

Checklist
  • documentation is added or updated
  • tests are added or updated

@DimitriPapadopoulos
Fix typos found by codespell in openssl-3.1
14baaa8 
Only modify doc/man* in the openssl-3.1 branch.
@t8m t8m added branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing and removed approval: otc review pending This pull request needs review by an OTC member labels Feb 12, 2024
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 12, 2024
@tom-cosgrove-arm
Copy link
Contributor

@t8m PR #23546 targets the 3.0 branch

@t8m t8m removed the branch: 3.0 Merge to openssl-3.0 branch label Feb 12, 2024
shahsb
shahsb approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@shahsb shahsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@tom-cosgrove-arm tom-cosgrove-arm added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 13, 2024
@t8m
Copy link
Member

t8m commented Feb 14, 2024

Merged to the 3.1 branch. Thank you for your contribution.

@t8m t8m closed this Feb 14, 2024
openssl-machine pushed a commit that referenced this pull request Feb 14, 2024
@DimitriPapadopoulos
Fix typos found by codespell in openssl-3.1
e9ca7da 
Only modify doc/man* in the openssl-3.1 branch.

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23544)
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell_man branch February 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@shahsb shahsb shahsb approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DimitriPapadopoulos @tom-cosgrove-arm @openssl-machine @t8m @shahsb