Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_addressPrefix(): Fix a memory leak in error case #24102

Closed
wants to merge 1 commit into from
Closed

make_addressPrefix(): Fix a memory leak in error case #24102

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 11, 2024

Fixes #24098

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels Apr 11, 2024
@t8m t8m mentioned this pull request Apr 11, 2024
Closed
@tom-cosgrove-arm tom-cosgrove-arm removed the approval: review pending This pull request needs review by a committer label Apr 11, 2024
@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Apr 11, 2024
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Apr 12, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Apr 12, 2024
@t8m
Copy link
Member Author

t8m commented Apr 12, 2024

Merged to all the active branches. Thank you for the reviews.

@t8m t8m closed this Apr 12, 2024
openssl-machine pushed a commit that referenced this pull request Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
d207c4c 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
openssl-machine pushed a commit that referenced this pull request Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
bfa293c 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
openssl-machine pushed a commit that referenced this pull request Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
a6d9343 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
openssl-machine pushed a commit that referenced this pull request Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
682ed1b 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)
openssl-machine pushed a commit that referenced this pull request Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
0f72768 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 21, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
2c2edd4 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 22, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
29b3021 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 23, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
c7b6fd9 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 23, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
ea25273 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Apr 23, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
34b5fcb 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@shahsb shahsb shahsb approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is a memory leak defect on line 413 of the file /openssl/crypto/x509/v3_addr.c.
5 participants
@t8m @openssl-machine @levitte @shahsb @tom-cosgrove-arm