Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a memory leak defect on line 413 of the file /openssl/crypto/x509/v3_addr.c. #24098

Closed
LuMingYinDetect opened this issue Apr 11, 2024 · 1 comment
Closed

There is a memory leak defect on line 413 of the file /openssl/crypto/x509/v3_addr.c. #24098

LuMingYinDetect opened this issue Apr 11, 2024 · 1 comment
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 triaged: bug The issue/pr is/fixes a bug

Comments

@LuMingYinDetect
Copy link

1.On line 410 of the file /openssl/crypto/x509/v3_addr.c, a pointer variable named 'aor' is defined and a dynamic memory area is allocated through the function IPAddressOrRange_new. When the if statement on line 412 returns true, the program will return on line 413, thereby bypassing the release operation on the memory area pointed to by the 'aor' pointer on line 430. This constitutes a memory leak defect, as shown in the diagram below:
https://github.com/LuMingYinDetect/openssl_defects/blob/main/openssl_4.png
@LuMingYinDetect LuMingYinDetect added the issue: bug report The issue was opened to report a bug label Apr 11, 2024
t8m added a commit to t8m/openssl that referenced this issue Apr 11, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
bb5d779 
Fixes openssl#24098
@t8m t8m mentioned this issue Apr 11, 2024
Closed
@t8m
Copy link
Member

t8m commented Apr 11, 2024

Fix in #24102

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 and removed issue: bug report The issue was opened to report a bug labels Apr 11, 2024
openssl-machine pushed a commit that referenced this issue Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
d207c4c 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
openssl-machine pushed a commit that referenced this issue Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
bfa293c 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
openssl-machine pushed a commit that referenced this issue Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
a6d9343 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
openssl-machine pushed a commit that referenced this issue Apr 12, 2024
@t8m
make_addressPrefix(): Fix a memory leak in error case
0f72768 
Fixes #24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Apr 21, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
2c2edd4 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Apr 22, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
29b3021 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Apr 23, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
c7b6fd9 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Apr 23, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
ea25273 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this issue Apr 23, 2024
@t8m @bernd-edlinger
make_addressPrefix(): Fix a memory leak in error case
34b5fcb 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)

(cherry picked from commit 682ed1b)
jvdsn pushed a commit to jvdsn/openssl that referenced this issue Jun 3, 2024
@t8m @jvdsn
make_addressPrefix(): Fix a memory leak in error case
302dba0 
Fixes openssl#24098

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#24102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make_addressPrefix(): Fix a memory leak in error case t8m/openssl
2 participants
@t8m @LuMingYinDetect