Update x509.h #24243
Closed
Update x509.h #24243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue openssl#20663 CSR v1 certificates should always be used. If other versions are used, it will result in CSRs that are invalid.
openssl-machine
added
the
hold: cla required
|
@bbbrumley |
| @@ -62,7 +68,7 @@ struct x509_sig_info_st { | |||
|
|
|||
| struct X509_req_info_st { | |||
| ASN1_ENCODING enc; /* cached encoding of signed part */ | |||
| ASN1_INTEGER *version; /* version, defaults to v1(0) so can be NULL */ | |||
| int ASN1_INTEGER = 0; /* CSR v1 will always be used */ | |||
There was a problem hiding this comment.
This is not valid C.
ASN1_INTEGER is a type, not the name of a structure member, and you can't give default values like this. In addition, changing from a pointer to an integer type would be a change of API (even if this was valid C).
|
Yes, @bbbrumley is right. This was already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #20663
CSR v1 certificates should always be used. If other versions are used, it will result in CSRs that are invalid. Therefore, all instances of setting the version were changed to use version 0, always.
CLA: trivial
Checklist