-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Windows installer #24277
Proposed Windows installer #24277
Conversation
make some improvements to the script. Realized we can group the installation sections into 64 and 32 bit groups for better organization. Also add in static libraries for users that want to statically link their own apps
run: nmake /S | ||
- name: build installer | ||
working-directory: windows-installer | ||
run: makensis.exe /DVERSION=${{ github.event.inputs.tag }} /DBUILD32=_build32 /DBUILD64=_build64 .\openssl.nsi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you run the command directly instead of running windows-installer/Makefile
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only because I created the ci workflow before I created the makefile, but I can fix that up
closing this - discussion from backlog refinement is that the installer should go into a separate repository |
As part of openssl/project#20 I've created this draft PR to propose a windows installer framework. The installer currently:
This PR expressly omits any offical building of the installer, as we need to determine how we would want to manage code signing certificates, as well as how we want to incorporate the building and releasing of the installer as part of our release process, but I think the installer itself is in pretty good shape. My proposal would be to incorporate this PR in 3.4 and target 3.5 for integrating a signed installer release into the 3.5 development cycle
Checklist