Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for __QNX__ define when using in_pktinfo.ipi_spec_dst #24361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added check for __QNX__ define when using in_pktinfo.ipi_spec_dst #24361

wants to merge 1 commit into from

Conversation

klausholstjacobsen
Copy link

Added check for QNX define when using in_pktinfo.ipi_spec_dst

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label May 10, 2024
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels May 10, 2024
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

@nhorman
Copy link
Contributor

nhorman commented Jul 11, 2024

Can you please sign a cla so that we can review and potentially accept this issue

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

@tom-cosgrove-arm
Copy link
Contributor

Why is the bot reporting an incorrect status? This PR needs a CLA, not OTC action - although TBH to me it looks like it could be accepted as trivial - it's extending a #if presumably based on a compiler error

@nhorman
Copy link
Contributor

nhorman commented Aug 12, 2024

I think the bot response is just an artifact of which label it checks first. As for trivial, I'm honestly not sure

@tom-cosgrove-arm
Copy link
Contributor

As for trivial, I'm honestly not sure

In which case @klausholstjacobsen can you sign and submit a CLA so we can review and hopefully accept this contribution?

@klausholstjacobsen
Copy link
Author

Yes, will do!

@t8m
Copy link
Member

t8m commented Sep 6, 2024

Was the CLA submitted? IMO this would be clearly OK with CLA: trivial as well.

@t8m t8m added branch: 3.4 Merge to openssl-3.4 and removed approval: otc review pending labels Sep 6, 2024
@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 9, 2024
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically,alternatively please review and set the label manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: 3.4 Merge to openssl-3.4 hold: cla required The contributor needs to submit a license agreement tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@klausholstjacobsen @openssl-machine @nhorman @tom-cosgrove-arm @t8m @hlandau