-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parentheses on public macros where appropriate #3100
Add parentheses on public macros where appropriate #3100
Conversation
I don't know how much of this PR can be cherry-picked for 1.1.0 and 1.0.2 |
please do that. |
Hmm... I for one would vote against taking it to released branches. |
okay, why? |
Because these are not bugs. |
I have to agree that this should go to the stable branches. |
What would the motivation be to take this to the stable branches? @dot-asm is right, these changes aren't bug fixes per se, and they don't make future backports easier (unless we're touching these specific macros, but that happens very seldom), so yeah, I also have a hard time motivating a backport... |
They seem to me to fix latent bugs, such as if you do p + 1 to the BIO set-host macro. |
Not quite, they rather prevent bugs. While definition of branch in maintenance mode is [actual] bug fixing. Well, we all know that we are quite liberal about this in 1.1.0 context, and this might be viewed as kind of a grey area, but public headers are are not as grey as rest of the code. Yes, there is contradiction here, public headers need it most, but their modification is not to be taken lightly. |
Ping? |
Approved for master only |
Pushed. Thanks. |
Code-health, although today is not Tuesday :)
Fixes #3063.