Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsa/rsa_ossl.c: fix and extend commentary [skip ci]. #7123

Closed
wants to merge 1 commit into from
Closed

rsa/rsa_ossl.c: fix and extend commentary [skip ci]. #7123

wants to merge 1 commit into from

Conversation

dot-asm
Copy link
Contributor

@dot-asm dot-asm commented Sep 5, 2018

No description provided.

@dot-asm dot-asm added branch: master Merge to master branch branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch 1.1.0 branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Sep 5, 2018
romen
romen approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romen romen added the approval: done This pull request has the required number of approvals label Sep 5, 2018
@mattcaswell mattcaswell added this to the Assessed milestone Sep 7, 2018
levitte pushed a commit that referenced this pull request Oct 12, 2018
rsa/rsa_ossl.c: fix and extend commentary [skip ci].
d1c008f 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from #7123)
levitte pushed a commit that referenced this pull request Oct 12, 2018
rsa/rsa_ossl.c: fix and extend commentary [skip ci].
a9e4192 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from #7123)

(cherry picked from commit d1c008f)
levitte pushed a commit that referenced this pull request Oct 12, 2018
rsa/rsa_ossl.c: fix and extend commentary [skip ci].
f7cbb8a 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from #7123)

(cherry picked from commit d1c008f)
levitte pushed a commit that referenced this pull request Oct 12, 2018
rsa/rsa_ossl.c: fix and extend commentary [skip ci].
b1016c9 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from #7123)

(cherry picked from commit d1c008f)
@dot-asm dot-asm closed this Oct 12, 2018
@mspncp mspncp modified the milestones: Assessed, 1.1.1a Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romen romen romen approved these changes

@levitte levitte levitte approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
1.1.1a
Development

Successfully merging this pull request may close these issues.
5 participants
@dot-asm @romen @levitte @mattcaswell @mspncp