Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OPENSSL_malloc_init() a no-op #8167

Closed
wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

Making this a no-op removes a potential infinite loop than can occur in
some situations.

Fixes #2865

Making this a no-op removes a potential infinite loop than can occur in
some situations.

Fixes openssl#2865
@mattcaswell
Copy link
Member Author

No one seems to know why this would ever be needed. I can't think of a good reason, and making it a no-op fixes the issue in #2865. If anyone can suggest why this shouldn't be done, please let me know!

@mattcaswell mattcaswell added branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Feb 5, 2019
@openssl openssl deleted a comment from Richardlucas123 Feb 6, 2019
levitte pushed a commit that referenced this pull request Feb 7, 2019
Making this a no-op removes a potential infinite loop than can occur in
some situations.

Fixes #2865

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #8167)

(cherry picked from commit ef45aa1)
@mattcaswell
Copy link
Member Author

Pushed. Thanks.

@mattcaswell mattcaswell closed this Feb 7, 2019
levitte pushed a commit that referenced this pull request Feb 7, 2019
Making this a no-op removes a potential infinite loop than can occur in
some situations.

Fixes #2865

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #8167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants