sha/asm/keccak1600-ppc64.pl: Load data in 8 byte chunks on little endian #8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
We currently load data byte by byte in order to byteswap it on big endian. On little endian we can just do 8 byte loads. A SHAKE128 benchmark runs 10% faster on POWER9 with this patch applied.
antonblanchard
force-pushed
the
ppc64le-sha3
branch
from
1335d41
to
44a1277
Compare
openssl-machine
removed
the
hold: cla required
t8m
added
branch: master
t8m
approved these changes
Jul 23, 2021
t8m
added
the
approval: review pending
github-actions
bot
added
the
severity: fips change
paulidale
approved these changes
Jul 24, 2021
paulidale
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
t8m
added
the
hold: merge after release
t8m
removed
the
hold: merge after release
openssl-machine
pushed a commit
that referenced
this pull request
Nov 11, 2021
We currently load data byte by byte in order to byteswap it on big endian. On little endian we can just do 8 byte loads. A SHAKE128 benchmark runs 10% faster on POWER9 with this patch applied. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #8455)
|
Merged to master branch, finally. Thank you for the contribution! |
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 2, 2022
We currently load data byte by byte in order to byteswap it on big endian. On little endian we can just do 8 byte loads. A SHAKE128 benchmark runs 10% faster on POWER9 with this patch applied. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#8455) (cherry picked from commit 8f9842f)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 9, 2022
We currently load data byte by byte in order to byteswap it on big endian. On little endian we can just do 8 byte loads. A SHAKE128 benchmark runs 10% faster on POWER9 with this patch applied. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #8455) (cherry picked from commit 8f9842f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently load data byte by byte in order to byteswap it on big
endian. On little endian we can just do 8 byte loads.
A SHAKE128 benchmark runs 10% faster on POWER9 with this patch applied.