Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT 4242: reject invalid EC point coordinates #8750

Commits on Apr 15, 2019

  1. RT 4242: reject invalid EC point coordinates

    This is a backport of commit 1e2012b to 1.0.2. This hardening change
    was made to 1.1.0 but was not backported to 1.0.2. Recent CVEs in user
    applications have shown this additional hardening in 1.0.2 would be
    beneficial.
    
    E.g. see the patch for CVE-2019-9498
    https://w1.fi/security/2019-4/0011-EAP-pwd-server-Verify-received-scalar-and-element.patch
    
    and CVE-2019-9499
    https://w1.fi/security/2019-4/0013-EAP-pwd-client-Verify-received-scalar-and-element.patch
    
    The original commit had this description:
    
    We already test in EC_POINT_oct2point that points are on the curve. To
    be on the safe side, move this check to
    EC_POINT_set_affine_coordinates_* so as to also check point coordinates
    received through some other method.
    
    We do not check projective coordinates, though, as
    - it's unlikely that applications would be receiving this primarily
      internal representation from untrusted sources, and
    - it's possible that the projective setters are used in a setting where
      performance matters.
    ekasper authored and mattcaswell committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    98e449e View commit details
    Browse the repository at this point in the history