Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style policy #16

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Coding style policy #16

merged 2 commits into from
Jan 25, 2022

Conversation

paulidale
Copy link
Contributor

@paulidale paulidale commented Dec 15, 2021

Relocation of coding style fro the web site to the technical policies repository.

There are no changes to the text, just to the formatting.

policies/coding-style.md Outdated Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Outdated Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
@paulidale
Copy link
Contributor Author

Comments addressed.

policies/coding-style.md Outdated Show resolved Hide resolved
@paulidale paulidale force-pushed the coding-style-policy branch 2 times, most recently from 6b1f564 to bad2ef7 Compare December 16, 2021 03:11
@t8m t8m added the ready to vote The policy change proposal is ready to be voted on by the OTC label Jan 11, 2022
@t8m
Copy link
Member

t8m commented Jan 11, 2022

Vote for accepting the policy at the commit id 22ea6d1 has started.

@t8m
Copy link
Member

t8m commented Jan 11, 2022

Vote: [+1]

2 similar comments
@t-j-h
Copy link
Member

t-j-h commented Jan 11, 2022

Vote: [+1]

@paulidale
Copy link
Contributor Author

Vote: [+1]

@DDvO
Copy link
Contributor

DDvO commented Jan 11, 2022

Hope that, after the text has been moved, #10725 can be addressed.

@mattcaswell
Copy link
Member

Vote: [+1]

@t8m
Copy link
Member

t8m commented Jan 11, 2022

Hope that, after the text has been moved, #10725 can be addressed.

Anybody will be able to suggest changes to the policy via PRs here once this PR is merged.

@beldmit
Copy link
Member

beldmit commented Jan 11, 2022

Vote: [+1]

@slontis
Copy link
Member

slontis commented Jan 11, 2022

Vote: [+1]

(Note that Chapter 13 has a few bad sentences that could be improved)

@kroeckx
Copy link
Member

kroeckx commented Jan 12, 2022

Vote: [+1]

@t8m
Copy link
Member

t8m commented Jan 17, 2022

I am going to close the vote tomorrow @mspncp @levitte @romen if you still want to vote, please do so now.

@levitte
Copy link
Member

levitte commented Jan 17, 2022

Vote: [0]

@mspncp
Copy link
Contributor

mspncp commented Jan 17, 2022

Vote: [+1]

@t8m
Copy link
Member

t8m commented Jan 25, 2022

Closing the vote now:

Topic: Accept openssl/technical-policies PR#16 - Coding style policy as of
commit 22ea6d1. This will become an official OTC policy.
Proposed by: Paul Dale
Issue link: https://github.com/openssl/technical-policies/pull/16
Public: yes
Opened: 2022-01-12
Closed: 2022-01-25
Accepted:  yes  (for: 8, against: 0, abstained: 1, not voted: 1)

  Dmitry     [+1]
  Matt       [+1]
  Pauli      [+1]
  Tim        [+1]
  Richard    [ 0]
  Shane      [+1]
  Tomas      [+1]
  Kurt       [+1]
  Matthias   [+1]
  Nicola     [  ]

@t8m t8m added accepted The policy change proposal was accepted by an OTC vote and removed ready to vote The policy change proposal is ready to be voted on by the OTC labels Jan 25, 2022
@t8m t8m merged commit 5dbdc4b into openssl:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The policy change proposal was accepted by an OTC vote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants