-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Design Process Policy #3
Conversation
There is currently no policy which describes how designs for significant solutions to be incorporated into OpenSSL are arrived at. This policy provides a process for doing that.
"Refine and document" stage to fill in those details when they are eventually | ||
required, and the subsequent amended design document must be agreed again by the | ||
OTC. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need some sort of a review solution. The original design could miss some crucial points or see a better approach, so the design will require some changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this as happening on github in the pull request, i.e. in the "refine and document" step the design document is made available as a PR on which people can make comments. The document is updated accordingly to take account of comments. Eventually the document stabilises sufficiently that OTC are asked to agree it. Either they agree, or they think it needs more work in which case it goes back to "refine and document" as stated above, i.e. "The OTC may choose not to agree a solution. In this case the process should iterate back to the "Refine and document" step to incorporate feedback from the OTC."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
I've pushed an update with the updates from the feedback above as well as incorporating feedback from the OTC meeting last week. Are there any more comments or can we start a vote on this? |
|
||
### Refine and document | ||
|
||
In this step the design team provide further detail on the selected solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: provides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"provide" seems correct here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to hinge on whether the noun "design team" is considered singular or plural. I would say "the design team provides", but "the design team members provide".
Further fixup pushed addressing additional feedback |
I've updated this PR to take account of the latest feedback and to incorporate feedback from today's OTC meeting. Barring further significant comments I plan to open a vote on this tomorrow. |
Vote [+1] |
@openssl/otc: VOTE NOW OPEN. Please record your votes in this PR |
Vote [+1] |
5 similar comments
Vote [+1] |
Vote [+1] |
Vote [+1] |
Vote [+1] |
Vote [+1] |
Volte [+1] |
Vote [+1] |
vote [+1] |
Closed - pass - 10 Yes, 0 No, 0 abstension. |
There is currently no policy which describes how designs for
significant solutions to be incorporated into OpenSSL are arrived at.
This policy provides a process for doing that.