Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Design Process Policy #3

Closed
wants to merge 4 commits into from

Conversation

mattcaswell
Copy link
Member

There is currently no policy which describes how designs for
significant solutions to be incorporated into OpenSSL are arrived at.
This policy provides a process for doing that.

There is currently no policy which describes how designs for
significant solutions to be incorporated into OpenSSL are arrived at.
This policy provides a process for doing that.
"Refine and document" stage to fill in those details when they are eventually
required, and the subsequent amended design document must be agreed again by the
OTC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need some sort of a review solution. The original design could miss some crucial points or see a better approach, so the design will require some changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this as happening on github in the pull request, i.e. in the "refine and document" step the design document is made available as a PR on which people can make comments. The document is updated accordingly to take account of comments. Eventually the document stabilises sufficiently that OTC are asked to agree it. Either they agree, or they think it needs more work in which case it goes back to "refine and document" as stated above, i.e. "The OTC may choose not to agree a solution. In this case the process should iterate back to the "Refine and document" step to incorporate feedback from the OTC."

policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
@mattcaswell
Copy link
Member Author

I've pushed an update with the updates from the feedback above as well as incorporating feedback from the OTC meeting last week. Are there any more comments or can we start a vote on this?

policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved

### Refine and document

In this step the design team provide further detail on the selected solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: provides

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"provide" seems correct here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to hinge on whether the noun "design team" is considered singular or plural. I would say "the design team provides", but "the design team members provide".

policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
@mattcaswell
Copy link
Member Author

Further fixup pushed addressing additional feedback

policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
policies/design-process.md Outdated Show resolved Hide resolved
@mattcaswell
Copy link
Member Author

I've updated this PR to take account of the latest feedback and to incorporate feedback from today's OTC meeting. Barring further significant comments I plan to open a vote on this tomorrow.

@t8m t8m added the ready to vote The policy change proposal is ready to be voted on by the OTC label Nov 23, 2021
@t-j-h
Copy link
Member

t-j-h commented Nov 23, 2021

Vote [+1]

@mattcaswell
Copy link
Member Author

@openssl/otc: VOTE NOW OPEN.

Please record your votes in this PR

@mattcaswell
Copy link
Member Author

mattcaswell commented Nov 23, 2021

Vote [+1]

5 similar comments
@romen
Copy link
Member

romen commented Nov 23, 2021

Vote [+1]

@t8m
Copy link
Member

t8m commented Nov 23, 2021

Vote [+1]

@mspncp
Copy link
Contributor

mspncp commented Nov 23, 2021

Vote [+1]

@beldmit
Copy link
Member

beldmit commented Nov 23, 2021

Vote [+1]

@kroeckx
Copy link
Member

kroeckx commented Nov 23, 2021

Vote [+1]

@paulidale
Copy link
Contributor

Volte [+1]

@slontis
Copy link
Member

slontis commented Nov 30, 2021

Vote [+1]

@levitte
Copy link
Member

levitte commented Nov 30, 2021

vote [+1]

@t8m t8m added accepted The policy change proposal was accepted by an OTC vote and removed ready to vote The policy change proposal is ready to be voted on by the OTC labels Nov 30, 2021
@t-j-h
Copy link
Member

t-j-h commented Nov 30, 2021

Closed - pass - 10 Yes, 0 No, 0 abstension.

@t-j-h t-j-h closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The policy change proposal was accepted by an OTC vote
Projects
None yet
Development

Successfully merging this pull request may close these issues.