Enhance handshake test to offer a variant of the test in which ssl_ctx objects are allocated per connection #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're adding a new option to not share ctx objects, and its getting hard to manage multiple options, so switch to using getopt
To better understand our performance behavior, add an option to the handshake test to allow the threads to repeatedly allocate their own contexts per connection. If -s is specified this will be the behavior. Omitting -s uses the default behavior, which is to share an ssl_ctx among all connections
mattcaswell
requested changes
May 27, 2024
|
A separate thought on this. It would be quite useful to have a performance test which only creates |
|
@mattcaswell I like the idea of a test for creating ssl_ctx objects. I'll create a separate test for that |
mattcaswell
approved these changes
May 29, 2024
paulidale
approved these changes
Jun 4, 2024
|
Merged. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2024
We're adding a new option to not share ctx objects, and its getting hard to manage multiple options, so switch to using getopt Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from #195)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2024
To better understand our performance behavior, add an option to the handshake test to allow the threads to repeatedly allocate their own contexts per connection. If -s is specified this will be the behavior. Omitting -s uses the default behavior, which is to share an ssl_ctx among all connections Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from #195)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 10, 2024
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from #195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while best practice is to create a single ssl_ctx object and share it among ssl connections, it often happens that existing code in the field creates a context per connection. to allow us to test performance in this environment, enhance the handshake test with the -s option. Specifying this option alters the test behavior such that contexts are created and freed per connection, rather than the default behavior which is to share a context