Wrap pip to force pip<20.3 and setuptools<50.0.0 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osci runs the CI jobs on Bionic, this version of tox (2.5) will automatically upgrade the packages at virtualenv creation and any pinning won't have effect since the virtualenv created is upgraded to the latest versions of pip and setuptools. This behavior was changed in tox 3.10 with the addition of the 'download' directive[0] Setuptools 58.0 dropped the support for use_2to3=true which is needed to install blessings (an indirect dependency of charm-tools) since then the gate got broken. Closes openstack-charmers#155 [0] tox-dev/tox@18147f4
lourot
suggested changes
Sep 21, 2021
|
FYI for future travelers: this change is being validated here |
lourot
approved these changes
Sep 21, 2021
ajkavanagh
reviewed
Sep 21, 2021
Comment on lines
+23
to
+27
| cp -fvp global/$charm_type/tox.ini charms/$charm/pip.sh | ||
| ;; | ||
| source-zaza) | ||
| cp -fvp global/$charm_type/tox.ini charms/$charm/tox.ini | ||
| cp -fvp global/$charm_type/tox.ini charms/$charm/pip.sh |
There was a problem hiding this comment.
Unfortunately there is a bug here: tox.ini -> pip.sh.
There was a problem hiding this comment.
🤦 will fix that in a new PR in a minute.
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 27, 2021
* Update charm-mysql-innodb-cluster from branch 'master'
to 1774de95b7d55616b25f09b199f48f98fb6c2c32
- Remove the openstack-upgrade action
The openstack-principle reactive layer brings both the
openstack-origin option and the openstack-upgrade
action, none of which being needed for this charm.
This layer has been used already since the very first
commit of this charm, most likely for no specific
reason.
Also synced tox/pip boilerplate in order to include:
* openstack-charmers/release-tools#156
* openstack-charmers/release-tools#157
Closes-Bug: #1944953
Change-Id: I001f435c648229b65fb718a78a33e6303a0faf11
openstack-mirroring
pushed a commit
to openstack/charm-mysql-innodb-cluster
that referenced
this pull request
Sep 27, 2021
The openstack-principle reactive layer brings both the openstack-origin option and the openstack-upgrade action, none of which being needed for this charm. This layer has been used already since the very first commit of this charm, most likely for no specific reason. Also synced tox/pip boilerplate in order to include: * openstack-charmers/release-tools#156 * openstack-charmers/release-tools#157 Closes-Bug: #1944953 Change-Id: I001f435c648229b65fb718a78a33e6303a0faf11
openstack-mirroring
pushed a commit
to openstack/charm-mysql-router
that referenced
this pull request
Sep 28, 2021
Small review of README Add Documentation section Minor changes Fix a bug by adding an admonishment Also synced tox/pip boilerplate in order to include: * openstack-charmers/release-tools#156 * openstack-charmers/release-tools#157 Closes-Bug: #1881171 Change-Id: I405e8f2692be76695ac3f57a7618deae98e45225 Co-authored-by: Aurelien Lourot <aurelien.lourot@canonical.com>
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 28, 2021
* Update charm-mysql-router from branch 'master'
to 9cc7f6f13a66eb7015c535c08f6ba31ef46cd92e
- Review README
Small review of README
Add Documentation section
Minor changes
Fix a bug by adding an admonishment
Also synced tox/pip boilerplate in order to include:
* openstack-charmers/release-tools#156
* openstack-charmers/release-tools#157
Closes-Bug: #1881171
Change-Id: I405e8f2692be76695ac3f57a7618deae98e45225
Co-authored-by: Aurelien Lourot <aurelien.lourot@canonical.com>
openstack-mirroring
pushed a commit
to openstack/charm-layer-openstack
that referenced
this pull request
Oct 13, 2021
Osci runs the CI jobs on Bionic, this version of tox (2.5) will automatically upgrade the packages at virtualenv creation and any pinning won't have effect since the virtualenv created is upgraded to the latest versions of pip and setuptools. This behavior was changed in tox 3.10 with the addition of the 'download' directive[0] Setuptools 58.0 dropped the support for use_2to3=true which is needed to install blessings (an indirect dependency of charm-tools) since then the gate got broken. This is similar to: openstack-charmers/release-tools#156 openstack-charmers/release-tools#157 Change-Id: I7f22cd744a7aa5747cca49f094a5efd041481a80 Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Oct 13, 2021
* Update charm-layer-openstack from branch 'master'
to 4793ceba5faeac659d9db9b5fc4edde325155710
- Wrap pip to force pip<20.3 and setuptools<50.0.0
Osci runs the CI jobs on Bionic, this version of tox (2.5) will
automatically upgrade the packages at virtualenv creation and any
pinning won't have effect since the virtualenv created is upgraded to
the latest versions of pip and setuptools. This behavior was changed in
tox 3.10 with the addition of the 'download' directive[0]
Setuptools 58.0 dropped the support for use_2to3=true which is needed to
install blessings (an indirect dependency of charm-tools) since then
the gate got broken.
This is similar to:
openstack-charmers/release-tools#156
openstack-charmers/release-tools#157
Change-Id: I7f22cd744a7aa5747cca49f094a5efd041481a80
Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Osci runs the CI jobs on Bionic, this version of tox (2.5) will
automatically upgrade the packages at virtualenv creation and any
pinning won't have effect since the virtualenv created is upgraded to
the latest versions of pip and setuptools. This behavior was changed in
tox 3.10 with the addition of the 'download' directive[0]
Setuptools 58.0 dropped the support for use_2to3=true which is needed to
install blessings (an indirect dependency of charm-tools) since then
the gate got broken.
Closes #155
[0] tox-dev/tox@18147f4