PCINetDevices: use sysfs to enumerate ethernet devices #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnordahl
force-pushed
the
enumerate-with-sysfs
branch
from
6312e95
to
9b02916
Compare
fnordahl
changed the title
fnordahl
changed the title
fnordahl
force-pushed
the
enumerate-with-sysfs
branch
from
9b02916
to
a1513a9
Compare
The `PCINetDevice` constructor already uses sysfs to initialize itself so this would not introduce a behavioural change. It does however allow use of the PCI library with the `netdevsim` driver which would help in downstream testing. Use existence of `sriov_numvfs` as indication of SR-IOV support instead of `sriov_totalvfs` to allow testing with `netdevsim`. Handle non-existence of `sriov_totalvfs` by detecting the `netdevsim` driver and returning a fixed number for totalvfs.
fnordahl
force-pushed
the
enumerate-with-sysfs
branch
from
a1513a9
to
9e01a7b
Compare
Pass on device details when instantiating the PCINetDevice objects instead of enumerating devices twice.
|
In addition to on-metal testing successful test run consuming this code can be viewed in https://review.opendev.org/c/x/charm-ovn-chassis/+/780592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PCINetDeviceconstructor already uses sysfs to initializeitself so this would not introduce a behavioural change. It
does however allow use of the PCI library with the
netdevsimdriver which would help in downstream testing.
Use existence of
sriov_numvfsas indication of SR-IOV supportinstead of
sriov_totalvfsto allow testing withnetdevsim.Handle non-existence of
sriov_totalvfsby detecting thenetdevsimdriver and returning a fixed number for totalvfs.