Add Watcher Test Case #1101
Merged
Add Watcher Test Case #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add get_watcher_session_client() helper function to build a watcherclient.v1.Client instance authenticated with a keystone session that uses admin credentials by default.
This allows callers to pass None and let get_nova_session_client() to use a sane default API, specifically this allows intermediate users (e.g. launch_guest() ) to proxy values passed by the caller.
This change exposes two new parameters in the launch_instance() function: - nova_api_version: Set the microversion the novaclient should use. - host: Request to launch the instance on a specific hypervisor host.
The stop_status parameter allows callers to ask stop retrying based on a
list of statuses that are known to be final (and error) states, this
saves time failing earlier.
Usage example for fail early when an instance reaches to ERROR status:
openstack_utils.resource_reaches_status(self.nova_client.servers,
instance_uuid,
resource_attribute='state',
expected_status='ACTIVE',
stop_status='ERROR')
This simplifies when developing new tests and the programmer is not too familiar with the different attributes an object has.
This test launches 1 instance per hypervisor, and then launches a new audit to optimize the use of hypervisors and consolidate the instances in a single hypervisor, but also disabling the nova-compute service to avoid new instances get allocated.
ajkavanagh
reviewed
Aug 25, 2023
zaza/openstack/configure/guest.py
Outdated
| :param host: Requested host to create servers | ||
| :type host: str | ||
| :param nova_api_version: Nova API version to use | ||
| :type nova_api_version: str |
There was a problem hiding this comment.
I think this should be:
:type nova_api_version: str | None
There was a problem hiding this comment.
4491642 - this commit addresses this.
|
@freyes just pending a gerrit review that exercises this; please could you link one into the description for posterity' sake? |
|
this PR is being exercised by this gerrit review:
https://review.opendev.org/c/openstack/charm-watcher/+/891195
…On Fri, 2023-08-25 at 09:39 -0700, Alex Kavanagh wrote:
@freyes just pending a gerrit review that exercises this; please could you link one into the
description for posterity' sake?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ajkavanagh
approved these changes
Sep 4, 2023
openstack-mirroring
pushed a commit
to openstack/charm-watcher
that referenced
this pull request
Sep 5, 2023
This change expands the testing bundles to deploy a fully functional cloud and run the testing class WatcherTests which uses the vm_workload_consolidation strategy[0]. [0] https://docs.openstack.org/watcher/latest/strategies/basic-server-consolidation.html Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1101 Change-Id: I5a1d9ef50ce16d553a06382e0825fcbb2d12e887
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 5, 2023
* Update charm-watcher from branch 'master'
to 27c563dd5e90af4371a5124f7358b186a8a45d02
- Add zaza-openstack-tests testing.
This change expands the testing bundles to deploy a fully functional
cloud and run the testing class WatcherTests which uses the
vm_workload_consolidation strategy[0].
[0] https://docs.openstack.org/watcher/latest/strategies/basic-server-consolidation.html
Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1101
Change-Id: I5a1d9ef50ce16d553a06382e0825fcbb2d12e887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new test case for OpenStack Watcher which uses the vm_workload_consolidation strategy[0]
Used/verified by this gerrit review:
https://review.opendev.org/c/openstack/charm-watcher/+/891195
[0] https://docs.openstack.org/watcher/latest/strategies/basic-server-consolidation.html