Retry when checking ceph pool compression mode. [zed backport] #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compression mode after it's set via config-changed might take a while to fully propagate to the whole cluster, hence the hook may be done before the cluster is fully configured with the new compression mode. This is more noticeable in the gate when there are many jobs running in parallel. This patch modes the check to its own method wrapped with a tenacity.retry decorator to make the test more robust. Closes openstack-charmers#946 (cherry picked from commit 618fb7b)
|
This PR is being exercised by https://review.opendev.org/c/openstack/charm-gnocchi/+/893997 |
freyes
changed the title
ajkavanagh
approved these changes
Sep 8, 2023
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 8, 2023
Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1120 Change-Id: I107494cf2e04fa2eac631b6ae5544487a74ac872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compression mode after it's set via config-changed might take a while to fully propagate to the whole cluster, hence the hook may be done before the cluster is fully configured with the new compression mode. This is more noticeable in the gate when there are many jobs running in parallel.
This patch modes the check to its own method wrapped with a tenacity.retry decorator to make the test more robust.
Closes #946
(cherry picked from commit 618fb7b)