add test for virtual hosted bucket #1187
Conversation
Closes-Bug: #1871745 Change-Id: I295baab496d1eb95daaa8073d4119d01b90d0b38 func-test-pr: openstack-charmers/zaza-openstack-tests#1187
| # test virtual hosted bucket | ||
| logging.info('Testing virtual hosted bucket') | ||
| primary_client.Bucket(container_name).Acl().put(ACL='public-read') | ||
| primary_client.Object(container_name,obj_name).Acl().put(ACL='public-read') |
There was a problem hiding this comment.
One doubt around this. The above makes the test container publically available. Later on the test checks access for the test container using test credentials. Given that the container is now publically available, would the test credentials even be considered then?
I feel it would be preferable to isolate this test into a test method of it's own (and not share a container name with the other tests), also given that this test method is awfully long already
There was a problem hiding this comment.
This test is moved to test_005_virtual_hosted_bucket function
| primary_client.Object(container_name,obj_name).Acl().put(ACL='public-read') | ||
| public_hostname = zaza_model.get_application_config(self.primary_rgw_app)["os-public-hostname"]["value"] | ||
| url = primary_endpoint + "/" + obj_name | ||
| headers = {'host': container_name + "." + public_hostname} |
There was a problem hiding this comment.
Minor style nit: suggest to use f-strings for readability
url = f"{primary_endpoint}/{obj_name}"
headers = {'host': f"{container_name}.{public_hostname}"}
shundezhang
force-pushed
the
master
branch
2 times, most recently
from
c15006c
to
0b8324f
Compare
shundezhang
force-pushed
the
master
branch
7 times, most recently
from
ea541ea
to
83ab504
Compare
|
@shundezhang hi; it would be really useful if you didn't force push, please. Each time you do, you erase the previous commits which makes it really hard to see what the differences are between your commits, which also slows down the review process. We can squash small edits down as part of the merge. Thanks. |
|
@ajkavanagh sure will do. Actually it is easier for me to not force push. |
func-test-pr: openstack-charmers/zaza-openstack-tests#1187 Closes-Bug: #1871745 Change-Id: I295baab496d1eb95daaa8073d4119d01b90d0b38
* Update charm-ceph-radosgw from branch 'master'
to 6f2a7540e8102fc7575731e7e059695cd1c28a76
- Add a config option for virtual hosted bucket
func-test-pr: openstack-charmers/zaza-openstack-tests#1187
Closes-Bug: #1871745
Change-Id: I295baab496d1eb95daaa8073d4119d01b90d0b38
Add integration test for the virtual hosted bucket feature proposed to the upstream ceph-radosgw Juju charm:
https://review.opendev.org/c/openstack/charm-ceph-radosgw/+/904554