Migrate 499 cinder-ceph test to zaza #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkavanagh
force-pushed
the
cinder-ceph-additional-tests
branch
from
4fac7f8
to
ce2b067
Compare
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 20.48% 20.39% -0.09%
==========================================
Files 129 133 +4
Lines 7206 7236 +30
==========================================
Hits 1476 1476
- Misses 5730 5760 +30
Continue to review full report at Codecov.
|
ajkavanagh
force-pushed
the
cinder-ceph-additional-tests
branch
from
ce2b067
to
29b78e5
Compare
This takes the 499 test from basic_deployment.py (Amulet) test and ports it over to zaza.
The cinder tests were written with the assumption that cinder was the charm that was under test. This modifies the test so that the cinder tests work in a model with cinder where cinder isn't the application that is being explicitly tested.
This is the missing 500 test from the previous amulet tests that were missed on the first pass.
ajkavanagh
force-pushed
the
cinder-ceph-additional-tests
branch
from
b7d2d52
to
4c2f723
Compare
There was a race before a block_until_all_units_idle() where it could blast through the check before it started removing the relation. This ensures that it waits until something happens and then waits for it to finish.
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 20.35% 19.85% -0.50%
==========================================
Files 136 138 +2
Lines 7429 7635 +206
==========================================
+ Hits 1512 1516 +4
- Misses 5917 6119 +202
Continue to review full report at Codecov.
|
|
Bug #289 raised for refactoring bits to zaza library. |
ChrisMacNaughton
approved these changes
May 20, 2020
openstack-mirroring
pushed a commit
to openstack/charm-cinder-ceph
that referenced
this pull request
May 20, 2020
Use the same assertions as the cinder charm. Also port the 499 original test, which is in the associated depends in zaza-openstack-tests. Change-Id: I86f2ab205d0f082dd6b185ccbfa314bccf4e5bfb func-test-pr: openstack-charmers/zaza-openstack-tests#246 Closes-Bug: #1828424
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 20, 2020
* Update charm-cinder-ceph from branch 'master'
- Move charm tests to zaza
Use the same assertions as the cinder charm. Also port the 499 original
test, which is in the associated depends in zaza-openstack-tests.
Change-Id: I86f2ab205d0f082dd6b185ccbfa314bccf4e5bfb
func-test-pr: openstack-charmers/zaza-openstack-tests#246
Closes-Bug: #1828424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the 499 test from basic_deployment.py (Amulet) test and
ports it over to zaza.