Disable the pristine disk check on focal #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test won't pass on serverstack due to the snapd taking a copy of the /mnt/vdb info at boot time and thus not being able to umount it is root without also running through all of the procs and checking if they also have it mounted. Thus, this just disables the test on focal and newer.
|
It has actually passed its test if you check on travis; it looks like the notification didn't get back to github for some reason. |
openstack-gerrit
pushed a commit
to openstack/charm-ceph-osd
that referenced
this pull request
Apr 27, 2020
Add bionic-ussuri and focal-ussuri (with mysql8 support) bundles. The associated func-test-pr is to disable the /dev/vdb pristine disk check as it doesn't work on focal. Change-Id: I00b2b739c97dc41b2f987f29e12844e6cf5e921c func-test-pr: openstack-charmers/zaza-openstack-tests#249
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 27, 2020
* Update charm-ceph-osd from branch 'master'
- Merge "Enable focal and ussuri as part of the gate tests"
- Enable focal and ussuri as part of the gate tests
Add bionic-ussuri and focal-ussuri (with mysql8 support) bundles.
The associated func-test-pr is to disable the /dev/vdb pristine disk
check as it doesn't work on focal.
Change-Id: I00b2b739c97dc41b2f987f29e12844e6cf5e921c
func-test-pr: openstack-charmers/zaza-openstack-tests#249
lourot
approved these changes
Apr 29, 2020
| current_release = zaza_openstack.get_os_release() | ||
| focal_ussuri = zaza_openstack.get_os_release('focal_ussuri') | ||
| if current_release >= focal_ussuri: | ||
| # NOTE(ajkavanagh) - focal (on ServerStack) is broken for /dev/vdb |
There was a problem hiding this comment.
If you have a link to a bug it would be nice to put it here, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test won't pass on serverstack due to the snapd taking a copy of the
/mnt/vdb info at boot time and thus not being able to umount it is root
without also running through all of the procs and checking if they also
have it mounted. Thus, this just disables the test on focal and newer.