Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_921_remove_and_add_unit #288

Merged
merged 1 commit into from
May 20, 2020
Merged

Skip test_921_remove_and_add_unit #288

merged 1 commit into from
May 20, 2020

Conversation

dshcherb
Copy link
Contributor

@dshcherb dshcherb commented May 19, 2020

Due to test stability issues we need to skip it and work on it after
release.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #288 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   19.85%   19.85%   -0.01%     
==========================================
  Files         138      138              
  Lines        7635     7636       +1     
==========================================
  Hits         1516     1516              
- Misses       6119     6120       +1     
Impacted Files Coverage Δ
...aza/openstack/charm_tests/rabbitmq_server/tests.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd0bca...51bce56. Read the comment docs.

Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could we add (or reference if it exists) a bug so that it is noted somewhere that this needs to be addressed.

Due to test stability issues we need to skip it and work on it after
release.
@dshcherb
Copy link
Contributor Author

@ajkavanagh A bug reference would definitely help: I added #290 with an explanation of the current state of affairs.

@dshcherb dshcherb requested a review from ajkavanagh May 20, 2020 07:31
@ajkavanagh ajkavanagh merged commit c66f1ea into openstack-charmers:master May 20, 2020
openstack-mirroring pushed a commit to openstack/charm-rabbitmq-server that referenced this pull request May 20, 2020
Partial-Bug: #1878452
Func-Test-PR: openstack-charmers/zaza-openstack-tests#288
Change-Id: I6e03ec2b918ca1fbb1563a981827c687814902c4
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request May 20, 2020
* Update charm-rabbitmq-server from branch 'master'
  - Pre-freeze 'make sync' and make list-unconsumed-queues more robust
    
    Partial-Bug: #1878452
    Func-Test-PR: openstack-charmers/zaza-openstack-tests#288
    Change-Id: I6e03ec2b918ca1fbb1563a981827c687814902c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants