Add OVS to OVN migration tests #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnordahl
force-pushed
the
ovn-charm
branch
9 times, most recently
from
589c373
to
023461f
Compare
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 18.57% 20.16% +1.58%
==========================================
Files 154 155 +1
Lines 8389 9270 +881
==========================================
+ Hits 1558 1869 +311
- Misses 6831 7401 +570
Continue to review full report at Codecov.
|
fnordahl
force-pushed
the
ovn-charm
branch
5 times, most recently
from
4e79462
to
6a84fa1
Compare
lourot
suggested changes
Sep 4, 2020
That part got merged already, I'll update the commit message. zaza-openstack-tests/zaza/openstack/charm_tests/test_utils.py Lines 113 to 119 in 334304e |
lourot
suggested changes
Sep 4, 2020
lourot
suggested changes
Sep 7, 2020
| on instances created prior to the migration. | ||
| """ | ||
| # The setUp method of this test class will perform the migration steps. | ||
| # The tests.yaml is programmed to to further validation after the |
This is done by building a prefix for options key from dot-notated absolute path to calling method or function.
Adjust NeutronNetworkingTest to optionally run tearDown and re-use existing instances on subsequent runs. tearDown is controlled through a key under the `tests_options` dictionary in tests.yaml. Useful for morphing a deployment and then validating connectivity for existing instances afterwards.
For compatibility with existing scenario tests the `configure_gateway_ext_port` helper currently make use of `juju_wait` when configuring the deployed cloud. This does not work well if the model you are testing has applications with non-standard workload status messaging. Allow to override the behaviour through config step options.
lourot
approved these changes
Sep 7, 2020
To support OVS to OVN migration checks we want the basic overcloud configure job to set up N-OVS and/or N-GW when present and the OVN pre migration configure job will copy the configuration for us.
thedac
suggested changes
Sep 8, 2020
There was a problem hiding this comment.
My apologies for taking so long to review. But as you might imaging I have several requests.
There are a handful of missing docstrings.
I would also like to get confirmation that regular OVS testing has been run against this PR as some of the common tests are affected.
I would like to get a discussion on the use of test_options.
Thank you for all the comments which made reading the code much easier and made a complex task understandable.
| # The reason for using the `config_change` helper for this | ||
| # is that it already deals with all the permutations of | ||
| # config already being set etc and does not get into | ||
| # trouble if the test bundle already have the values we try |
| def setUp(self): | ||
| """Perform migration steps prior to validation.""" | ||
| super(OVSOVNMigrationTest, self).setUp() | ||
| # These steps here due to them having to be executed once and in a |
Yes, the neutron-gateway, neutron-openvswitch and neutron-api-plugin-ovn have or will be tested with this PR both for regular and OVN migration jobs. |
fnordahl
commented
Sep 9, 2020
Merge two similar config set patterns into a common method. Add missing docstrings. Fix typos.
openstack-mirroring
pushed a commit
to openstack/charm-neutron-openvswitch
that referenced
this pull request
Sep 11, 2020
Add OVS to OVN migration at the end of the regular gate test. This adds only 5-10 minutes to each job and we want to confirm this works from focal-ussuri and onwards as this is the point where we recomend our end users to migrate from OVS to OVN. Do ch-sync. Merge after juju/charm-helpers#511 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#365 Depends-On: Ifa99988612eaaeb9d60a0d99db172f97e27cfc93 Change-Id: Ia4b1d3a9e642b540d1e04adc0363f9b3e11f37cd
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 11, 2020
* Update charm-neutron-openvswitch from branch 'master'
- Add cleanup action and OVS to OVN migration test
Add OVS to OVN migration at the end of the regular gate test. This
adds only 5-10 minutes to each job and we want to confirm this
works from focal-ussuri and onwards as this is the point where we
recomend our end users to migrate from OVS to OVN.
Do ch-sync.
Merge after juju/charm-helpers#511
Func-Test-Pr: openstack-charmers/zaza-openstack-tests#365
Depends-On: Ifa99988612eaaeb9d60a0d99db172f97e27cfc93
Change-Id: Ia4b1d3a9e642b540d1e04adc0363f9b3e11f37cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.