Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make determination of app under test more robust #440

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Oct 9, 2020

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #440 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   18.65%   18.63%   -0.02%     
==========================================
  Files         155      155              
  Lines        8847     8856       +9     
==========================================
  Hits         1650     1650              
- Misses       7197     7206       +9     
Impacted Files Coverage Δ
zaza/openstack/charm_tests/test_utils.py 36.94% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181bb98...f27ee7c. Read the comment docs.

Copy link
Contributor

@thedac thedac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The nova-cell-controller charm has passed its first test proving this works.

@thedac thedac merged commit 41c5434 into master Oct 9, 2020
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Oct 9, 2020
* Update charm-nova-cell-controller from branch 'master'
  - Sync libraries & common files prior to freeze
    
    * charm-helpers sync for classic charms
    * charms.ceph sync for ceph charms
    * rebuild for reactive charms
    * sync tox.ini files as needed
    * sync requirements.txt files to sync to standard
    
    Func-Test-Pr: openstack-charmers/zaza-openstack-tests#440
    Change-Id: I10a6a748b8fee04a0395da37d599e0c50d28f01c
openstack-mirroring pushed a commit to openstack/charm-nova-cell-controller that referenced this pull request Oct 9, 2020
* charm-helpers sync for classic charms
* charms.ceph sync for ceph charms
* rebuild for reactive charms
* sync tox.ini files as needed
* sync requirements.txt files to sync to standard

Func-Test-Pr: openstack-charmers/zaza-openstack-tests#440
Change-Id: I10a6a748b8fee04a0395da37d599e0c50d28f01c
@lourot lourot deleted the lourot/app-under-test branch October 12, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants