Functional tests for instance-count action on nova-compute charm.
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for `remove_from_cloud_actions` waits at the end until the nova-compute service is available again. However there's a few seconds lag until that host shows up also in `hypervisor-list` which can cause race conditions with other tests.
lourot
previously requested changes
Apr 7, 2021
ajkavanagh
dismissed
lourot’s stale review
The reason for holding has now passed; so we can now land this. Thanks @AurelienLourot for holding during freeze.
openstack-mirroring
pushed a commit
to openstack/charm-nova-compute
that referenced
this pull request
May 13, 2021
Closes-Bug: #1911011 Change-Id: If9ae646bc91b6389876830843bbf905596963054 func-test-pr: openstack-charmers/zaza-openstack-tests#535
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 13, 2021
* Update charm-nova-compute from branch 'master'
to 5eea014dd5e56c3205e1defbdc6253c5fbd8953a
- Add action that returns number of running VMs on the unit.
Closes-Bug: #1911011
Change-Id: If9ae646bc91b6389876830843bbf905596963054
func-test-pr: openstack-charmers/zaza-openstack-tests#535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launchpad: #1911011
Gerrit review: https://review.opendev.org/c/openstack/charm-nova-compute/+/783371