Fix neutron-api-plugin-ovn's num-expected-units #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After zaza#451 Zaza's application readiness detection has been improved, which now exposes issues from the past that were hidden. In other words, we were relying on a bug on Zaza's side and need to get this straight.
openstack-mirroring
pushed a commit
to openstack/charm-neutron-gateway
that referenced
this pull request
Jul 5, 2021
Fix Zaza's expected application status after openstack-charmers/zaza#451 Change-Id: I1a6f1316817a444d9cb82a4bc7e57d832a921eae func-test-pr: openstack-charmers/zaza-openstack-tests#598
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 5, 2021
* Update charm-neutron-gateway from branch 'master'
to 1cc3eba140116c80443c024ebfd09358b98f395a
- Fix Zaza deployment expectations
Fix Zaza's expected application status after
openstack-charmers/zaza#451
Change-Id: I1a6f1316817a444d9cb82a4bc7e57d832a921eae
func-test-pr: openstack-charmers/zaza-openstack-tests#598
|
FYI, the other way of doing this is just to delete the 'num-expected-units' key if it is present; this way it will mean 'at least one unit of x' rather than '1 unit of x exactly'. Maybe the key should have been "expect-units" and be a boolean?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After zaza#451 Zaza's application readiness detection
has been improved, which now exposes issues from the
past that were hidden. In other words, we were relying
on a bug on Zaza's side and need to get this straight.
Gerrit review making use of this: https://review.opendev.org/c/openstack/charm-neutron-gateway/+/799443