Workaround the URL formatting issue for product streams #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When glance-simplestreams-sync charm registers the 'product-streams' endpoint it uses a trailing slash. It's not clear whether this is a bug or not, and the behaviour may have changed in 2021. The impact is that the test fails, as it attempts to fetch with two '//' in the URL. This patch works around the test issue. It's not clear whether endpoints MUST be registered without a trailing slash or not; it would appear that most are not, but a quick glance at ServerStack show a few with trailing slashes.
ajkavanagh
force-pushed
the
workaround-product-streams-url
branch
from
ae3cf12
to
cccf227
Compare
openstack-mirroring
pushed a commit
to openstack/charm-glance-simplestreams-sync
that referenced
this pull request
Apr 11, 2022
- Add 22.04 to charmcraft.yaml - Update metadata to include jammy - Remove impish from metadata - Update osci.yaml to include py3.10 default job - Modify tox.ini to remove py35,py36,py37 tox target and add py310 target. - ensure that the openstack-origin is yoga func-test-pr: openstack-charmers/zaza-openstack-tests#745 Change-Id: I118ac221202fb02fc440a21910235fbc645a54c8
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 11, 2022
* Update charm-glance-simplestreams-sync from branch 'master'
to de4f9a6a978e0821d4a7a13507d1e93be5ef7f3d
- Updates to enable jammy and finalise charmcraft builds
- Add 22.04 to charmcraft.yaml
- Update metadata to include jammy
- Remove impish from metadata
- Update osci.yaml to include py3.10 default job
- Modify tox.ini to remove py35,py36,py37 tox target and add py310
target.
- ensure that the openstack-origin is yoga
func-test-pr: openstack-charmers/zaza-openstack-tests#745
Change-Id: I118ac221202fb02fc440a21910235fbc645a54c8
|
I'm closing this as I've fixed it in the charm (https://review.opendev.org/c/openstack/charm-glance-simplestreams-sync/+/837396) and thus this isn't needed and would mask an actual bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When glance-simplestreams-sync charm registers the 'product-streams'
endpoint it uses a trailing slash. It's not clear whether this is a bug
or not, and the behaviour may have changed in 2021. The impact is that
the test fails, as it attempts to fetch with two '//' in the URL. This
patch works around the test issue. It's not clear whether endpoints
MUST be registered without a trailing slash or not; it would appear that
most are not, but a quick glance at ServerStack show a few with trailing
slashes.