Setup loop devices early on in the Ceph tests #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a race condition between the loop device creation and its actual usage. In order to prevent that, this PR setups these devices during the test initialization instead of right before using them in the 'add-disk' tests.
|
Using https://review.opendev.org/c/openstack/charm-cinder-ceph/+/835283 to test this. |
openstack-mirroring
pushed a commit
to openstack/charm-cinder-ceph
that referenced
this pull request
Apr 13, 2022
- Add 22.04 to charmcraft.yaml - Update metadata to include jammy - Remove impish from metadata - Update osci.yaml to include py3.10 default job - Modify tox.ini to remove py35,py36,py37 tox target and add py310 target. - ensure that the openstack-origin is yoga func-test-pr: openstack-charmers/zaza-openstack-tests#751 Change-Id: Ia285c2d834cd0b9ab97fc944370172631995b83f
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 13, 2022
* Update charm-cinder-ceph from branch 'master'
to a8cfbe21f768cd6fe14f2a86999b6949a589afac
- Updates to enable jammy and finalise charmcraft builds
- Add 22.04 to charmcraft.yaml
- Update metadata to include jammy
- Remove impish from metadata
- Update osci.yaml to include py3.10 default job
- Modify tox.ini to remove py35,py36,py37 tox target and add py310
target.
- ensure that the openstack-origin is yoga
func-test-pr: openstack-charmers/zaza-openstack-tests#751
Change-Id: Ia285c2d834cd0b9ab97fc944370172631995b83f
ChrisMacNaughton
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a race condition between the loop device creation and its actual usage. In order to prevent that, this PR setups these devices during the test initialization instead of right before using them in the 'add-disk' tests.