Add retry logic around Trilio CRUD commands #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkavanagh
reviewed
May 30, 2022
| @tenacity.retry( | ||
| retry=tenacity.retry_if_exception_type(zaza_model.CommandRunFailed), | ||
| wait=tenacity.wait_fixed(10), # interval between retries | ||
| stop=tenacity.stop_after_attempt(5)) # retry 10 times |
There was a problem hiding this comment.
Comment and param don't match? e.g. 10 times vs 5.
| :rtype: string | ||
| :raises: model.CommandRunFailed | ||
| """ | ||
| logging.info("Running {}".format(remote_cmd)) |
There was a problem hiding this comment.
It's entirely optional, but I tend to use the %s form of interpolating into strings in logging commands as it's slightly more efficient as if the log doesn't happen (e.g. no info logs logged due to settings), it doesn't actually do the interpolation ... i.e. it makes it a bit lazy. The .format() always runs regardless of whether the log happens or not. I only found this out this year, and I've been doing it ever since!
openstack-mirroring
pushed a commit
to openstack/charm-trilio-dm-api
that referenced
this pull request
Jun 22, 2022
Due to a build problem with the reactive plugin, this change falls back
on overriding the steps and doing a manual build, but it also ensures
the CI system builds the charm using charmcraft. Changes:
- add a build-requirements.txt
- modify charmcraft.yaml
- modify osci.yaml
-> indicate build with charmcraft
- modify tox.ini
-> tox -e build does charmcraft build/rename
-> tox -e build-reactive does the reactive build
- modify bundles to use the <charm>.charm artifact in tests.
and fix deprecation warning re: prefix
- tox inception to enable tox -e func-test in the CI
- Pin everything in wheelhouse.txt for bionic and focal support.
This will need updating when the charm channels are created.
func-test-pr: openstack-charmers/zaza-openstack-tests#770
Change-Id: Ie0f9e4a80b81eaeb91ce11b84a54c7ecc95cdff2
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jun 22, 2022
* Update charm-trilio-dm-api from branch 'master'
to fa6223fa3afc98f4033e58c7bc16dbc96516e765
- Update to build using charmcraft
Due to a build problem with the reactive plugin, this change falls back
on overriding the steps and doing a manual build, but it also ensures
the CI system builds the charm using charmcraft. Changes:
- add a build-requirements.txt
- modify charmcraft.yaml
- modify osci.yaml
-> indicate build with charmcraft
- modify tox.ini
-> tox -e build does charmcraft build/rename
-> tox -e build-reactive does the reactive build
- modify bundles to use the <charm>.charm artifact in tests.
and fix deprecation warning re: prefix
- tox inception to enable tox -e func-test in the CI
- Pin everything in wheelhouse.txt for bionic and focal support.
This will need updating when the charm channels are created.
func-test-pr: openstack-charmers/zaza-openstack-tests#770
Change-Id: Ie0f9e4a80b81eaeb91ce11b84a54c7ecc95cdff2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.