Get ceph-dashboard's public addresses from the mon #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, Juju stopped returning a list of units for subordinate charms, so this test now fails to find the address for the dashboard units
This is partially picked out of d9a2c95
|
Hey there @ChrisMacNaughton ; is there an associated review that verifies this change please? |
|
https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/831510 is being used to validate this PR |
openstack-mirroring
pushed a commit
to openstack/charm-ceph-dashboard
that referenced
this pull request
Sep 23, 2022
This is the stable/pacific branch of the ceph charms. It tests against focal-ussuri (validates octopus) and focal-wallaby (validates pacific). As a minor fix-up, it also adds a versioned upstream zuul job to handle check and gate pipelines without breaking on future releases. Change-Id: Idda6cecbf3dcb5a42c67c358c8d259d782bb08e1 func-test-pr: openstack-charmers/zaza-openstack-tests#919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, Juju stopped returning a list of units for subordinate charms, so this test now fails to find the address for the dashboard units